Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment why unwrap() won't fail #113

Closed
Tracked by #120
dtolnay opened this issue May 31, 2017 · 1 comment
Closed
Tracked by #120

Comment why unwrap() won't fail #113

dtolnay opened this issue May 31, 2017 · 1 comment
Labels
E-easy Effort: Easy! Start here :D
Milestone
1.0

Comments

@dtolnay
Copy link

dtolnay commented May 31, 2017

There is some unwrapping going on in Client::redirect, Client::timeout, and RequestBuilder::send. If these can never fail, please include an explanation of how we know that. If any of them can fail, the method documentation should have a "Panics" section explaining what can trigger a panic.
@dtolnay dtolnay mentioned this issue May 31, 2017
Open
18 tasks
@seanmonstar seanmonstar added the E-easy Effort: Easy! Start here :D label May 31, 2017
@seanmonstar seanmonstar modified the milestone: 1.0 May 31, 2017
@seanmonstar
Copy link
Owner

These unwraps were removed completely, due to using the ClientBuilder and thus not needing state to change inside the Client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Effort: Easy! Start here :D
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@seanmonstar @dtolnay