Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting up CI Automated Checks #8

Open
noahjade opened this issue Mar 5, 2022 · 2 comments · May be fixed by #152 or #153
Open

Setting up CI Automated Checks #8

noahjade opened this issue Mar 5, 2022 · 2 comments · May be fixed by #152 or #153
Labels
approved initial set up setting up the project & infrastructure

Comments

@noahjade
Copy link
Contributor

noahjade commented Mar 5, 2022 •
edited
Loading

Description
We want to implement continuous integration for our project so that checks that can be done by machines don't have to be done by people during code review. This will free up developer time, and also ensure our project follows the standards we want.

Acceptance Criteria

  • All tests should be run and checked that they pass.
  • Lint/Prettier (whichever we end up using) rules should be checked.

Implementation details
This will be set up after initial project skeleton has been merged to main.
Likely configure these with a mix of library set ups and github actions.

Reviewer
@dkap937-209
@noahjade noahjade added the set up setting up the project & infrastructure label Mar 5, 2022
@noahjade noahjade self-assigned this Mar 5, 2022
@dkap937-209
Copy link
Collaborator

LGTM

@noahjade noahjade removed their assignment Mar 17, 2022
This was linked to pull requests Mar 19, 2022
Create backend_ci.yml #152
Open
Create frontend_ci.yml #153
Open
@noahjade
Copy link
Contributor Author

Linked PRs implement this, however they cannot be merged right now due to failing tests and lint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved initial set up setting up the project & infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create backend_ci.yml se701team3/Forgettable
Create frontend_ci.yml se701team3/Forgettable
2 participants
@noahjade @dkap937-209