Allow string type to be controlled from the public API #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostming
reviewed
Feb 11, 2022
frostming
reviewed
Feb 11, 2022
frostming
reviewed
Feb 11, 2022
|
Thank you very much for the kind review @frostming. I changed the implementation to address escaping properly trying to follow what the standard has to say about which characters and sequences that can or cannot appear in the string value... (P.S.: I had one doubt about the standard text, so I opened this issue: toml-lang/toml#877) |
Previously invalid chars were being escaped for the sake of not having invalid strings. It is preferable instead to explicitly fail.
frostming
approved these changes
Feb 13, 2022
capuanob
pushed a commit
to capuanob/tomlkit
that referenced
this pull request
Mar 1, 2023
…ings Allow string type to be controlled from the public API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, it would be interesting to expose a way of controlling the string style (e.g. allowing multi line strings).
This PR is an attempt to provide such API.
I ended up going for a very verbose API (with explicit keywords) because I believe that it is easier to use, but please let me know if you prefer exposing
StringTypeas part of the public API.I think this closes #44.