Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better workarounds for MPS bug #507

Closed
2 tasks
sdatkinson opened this issue Nov 24, 2024 · 1 comment · Fixed by #509
Closed
2 tasks

Better workarounds for MPS bug #507

sdatkinson opened this issue Nov 24, 2024 · 1 comment · Fixed by #509
Assignees

Comments

@sdatkinson
Copy link
Owner

  • Exclude PyTorch 2.5.0 and 2.5.1 from requirements. (TBD 2.5.2).
  • Keep the workaround and print a longer error message if the chunking fallback is used so that folks have more info to relay. I want to hear if this is still a problem in future versions of PyTorch.
@sdatkinson sdatkinson self-assigned this Nov 24, 2024
@sdatkinson
Copy link
Owner Author

On second thought, adding constraints to NAM's dependencies may cause it to be harder to integrate with other code. That's always a pain, so I'm not going to impose extra restrictions on its requirements since the workaround works (but at a performance hit--and usually only in validation).

If folks want to, they can dodge the versions of PyTorch that are problematic with this in conda YAML:

  - pytorch<2.5.0
  - pytorch>2.5.1. # And possibly more--we'll see.

or this in pip:

torch!=2.5.0,!=2.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant