Bump verrsion of chrono dependency #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In scylla-cql/src/frame/response/cql_to_rust.rs we use `DateTime::<Utc>::from_naive_utc_and_offset` but it was introduced in chrono 0.4.27. This commits bumps this dependency to correct version.
piodul
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
LGTM
Apparently, there is a flag in cargo that allows to resolve minimal versions of the dependencies (https://doc.rust-lang.org/cargo/reference/unstable.html?highlight=minimal-versions#minimal-versions) but, due to the fact that many crates in the ecosystem don't specify correct minimal versions, it's not available on stable. Maybe if the situation improves we can consider this as a CI check in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scylla-cql/src/frame/response/cql_to_rust.rs we use
DateTime::<Utc>::from_naive_utc_and_offsetbut it was introduced in chrono 0.4.27. This PR bumps this dependency to correct version.Pre-review checklist
./docs/source/.Fixes:annotations to PR description.