New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

value: implement serialize for u8 slices #790

Merged

wprzytula merged 1 commit into scylladb:main from koheatel:u8_slice_value_serialization

Aug 22, 2023

Contributor

koheatel commented Aug 19, 2023

Implement Value for u8 slices to allow deriving ValueList for structs with &[u8] fields.

Pre-review checklist

I have split my patch into logically separate commits.
All commit messages clearly explain what they change and why.
I added relevant tests for new features and bug fixes.
All commits compile, pass static checks and pass test.
PR description sums up the changes and reasons why they should be introduced.
I have provided docstrings for the public items that I want to introduce.
I have adjusted the documentation in ./docs/source/.
I added appropriate Fixes: annotations to PR description.


          value: implement serialize for u8 slices

e12cb12

wprzytula requested review from piodul and wprzytula

August 21, 2023 06:50

wprzytula approved these changes

View reviewed changes

wprzytula requested a review from cvybhu

August 21, 2023 07:40

wprzytula merged commit 48f393f into scylladb:main

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet