Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some tests to integration #1102

Merged
merged 12 commits into from
Nov 20, 2024

Conversation

Lorak-mmk
Copy link
Collaborator

@Lorak-mmk Lorak-mmk commented Oct 22, 2024

This is the first step towards improved integration tests.
Tests that require a running cluster should be in integration tests.

This PR moves some of such tests. Not all - for that there are a few other changes needed, but I wanted to merge what I already have.

Ref: #1097
Fixes: #1048

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

Copy link

github-actions bot commented Oct 22, 2024

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: 2b5a084

@Lorak-mmk Lorak-mmk force-pushed the overhaul-integration-tests branch 2 times, most recently from abfb810 to a554fa2 Compare November 4, 2024 13:06
@Lorak-mmk Lorak-mmk self-assigned this Nov 4, 2024
@Lorak-mmk
Copy link
Collaborator Author

1st push: rebased on main
2nd push: Fixed errors, fixed minor related issue (#1048)

@Lorak-mmk Lorak-mmk requested a review from wprzytula November 4, 2024 13:07
@Lorak-mmk Lorak-mmk force-pushed the overhaul-integration-tests branch from a554fa2 to ef8e2e7 Compare November 4, 2024 13:21
@Lorak-mmk
Copy link
Collaborator Author

Fixed errors in serverless tests

@Lorak-mmk Lorak-mmk requested a review from muzarski November 4, 2024 13:40
scylla/src/lib.rs Outdated Show resolved Hide resolved
@Lorak-mmk Lorak-mmk force-pushed the overhaul-integration-tests branch from ef8e2e7 to 4800a5d Compare November 5, 2024 17:02
@Lorak-mmk Lorak-mmk requested a review from muzarski November 5, 2024 17:36
wprzytula
wprzytula previously approved these changes Nov 11, 2024
Copy link
Collaborator

@wprzytula wprzytula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge it before #1057 is merged - it's going to introduce a lot of painful conflicts for me.

@Lorak-mmk
Copy link
Collaborator Author

  • Rebased on main
  • Made a small change in "supports_feature": Now it uses zero-copy deserialization.

@Lorak-mmk Lorak-mmk force-pushed the overhaul-integration-tests branch from 156deee to 2b5a084 Compare November 20, 2024 14:55
@Lorak-mmk Lorak-mmk merged commit be14812 into scylladb:main Nov 20, 2024
11 checks passed
wprzytula pushed a commit to wprzytula/scylla-rust-driver that referenced this pull request Dec 11, 2024
…tests

Move some tests to integration

(cherry picked from commit be14812)
@wprzytula wprzytula mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the way tablet support is checked in tests
3 participants