Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail gracefully when circles have invalid radius #655

Closed
LucaMarconato opened this issue Aug 1, 2024 · 3 comments
Closed

Fail gracefully when circles have invalid radius #655

LucaMarconato opened this issue Aug 1, 2024 · 3 comments

Comments

@LucaMarconato
Copy link
Member

The PR #653 breaks compatibility with older datasets. We should address this and have a way for the framework to fail in a way that the user is prompted in what to do.

@LucaMarconato
Copy link
Member Author

Here a better solution would be to have a migration tool which loads recomputes the radius of the circles and replaces the old shapes element with the new radius.

@LucaMarconato
Copy link
Member Author

LucaMarconato commented Aug 1, 2024

I think we should proceed as follows:

  • in the longer term, we should consider having a migration tool to deal with cases like this
  • for the moment we should keep throwing the error raise a warning and add "If this are seeing this error upon opening Xenium 2.0 data, please see this link for a solution: link_to_github_discussion". Then we should put a global setting that relaxes the validation against nan and in the discussion we should ask the user to enable this setting. The users will then be able to read the data, call to_circles() from the cell polygons get the correct circles from the table and save the data with write_element(). We should also tell the user that if regenerating the data is an option, they can just re-run the script.

@LucaMarconato
Copy link
Member Author

I have addressed this with #658 and the discussion #657.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant