Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transparent ShapesModel.parse geometry arguments #315

Open
MobiTobi opened this issue Jun 30, 2023 · 1 comment
Open

transparent ShapesModel.parse geometry arguments #315

MobiTobi opened this issue Jun 30, 2023 · 1 comment

Comments

@MobiTobi
Copy link
Collaborator

The geometry argument is used to select which kind of shapes to create when using ShapesModel.parse.
The possible arguments are 0, 3 and 6 which map to Circles, Polygon and MultiPolygon respectively.

Instead of relying on an incomplete enumeration of GEOS geometry types the argument should accept strings ( "circles", "polygon", "multipolygon").
@LucaMarconato
Copy link
Member

@giovp I also like this proposal, could you implement it please when doing the io refactoring?

@LucaMarconato LucaMarconato mentioned this issue Jul 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LucaMarconato @MobiTobi