Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No reloading after saving #297

Open
2 tasks
LucaMarconato opened this issue Jun 14, 2023 · 0 comments
Open
2 tasks

No reloading after saving #297

LucaMarconato opened this issue Jun 14, 2023 · 0 comments
Assignees

Comments

@LucaMarconato
Copy link
Member

  • Currently when write() is called, the data is re-read to be made lazy. We have to prevent this because it leads to undesired behavior when one wants to overwrite the data (i.e. data that was in memory should remain in-memory unless the user explicitly wants to load it lazily).
  • In doing this we need to warn the user that the in-memory object may be not performant (especially relevant if calling Interactive() to the output of functions like xenium()). So we should add a check that controls if the data is lazy and backed by a .zarr or .parquet storage (we already have the code for that (see the tests test_io_and_lazy_loading_points() and test_io_and_lazy_loading_raster()), if it is not backed, then when calling Interactive() we should display this warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants