You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The .geojson parsed (currently in spatialdata.models.ShapesModels.parse(), which will be moved to spatialdata-io, doesn't try to parse the index of the object from the .geojson file.
This behavior should be implemented. For instance in the incoming seqFISH reader #227 the index is assumed to match the index from the table (which is reasonable and expected), but more robust parser would read it from the .geojson.
Hi @LucaMarconato!
In the current PR for the CLI (#239), they call ShapesModels.parse() inside spatialdata-io instead of moving the function itself. Which option do you prefer? I'm fine with both.
(just to know if we need to do make PR in spatialdata, or update the spatialdata-io PR)
I think it will be cleaner to move the function inside spatialdata-io so that the parser is detached from reading from files. I will review the PRs shortly after the incoming release.
The
.geojson
parsed (currently inspatialdata.models.ShapesModels.parse()
, which will be moved tospatialdata-io
, doesn't try to parse theindex
of the object from the.geojson
file.This behavior should be implemented. For instance in the incoming seqFISH reader #227 the index is assumed to match the index from the table (which is reasonable and expected), but more robust parser would read it from the
.geojson
.CC @LLehner @quentinblampey
The text was updated successfully, but these errors were encountered: