Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In .geojson parsed, the index should be parsed from .geojson #249

Open
LucaMarconato opened this issue Dec 12, 2024 · 2 comments
Open

In .geojson parsed, the index should be parsed from .geojson #249

LucaMarconato opened this issue Dec 12, 2024 · 2 comments

Comments

@LucaMarconato
Copy link
Member

LucaMarconato commented Dec 12, 2024

The .geojson parsed (currently in spatialdata.models.ShapesModels.parse(), which will be moved to spatialdata-io, doesn't try to parse the index of the object from the .geojson file.

This behavior should be implemented. For instance in the incoming seqFISH reader #227 the index is assumed to match the index from the table (which is reasonable and expected), but more robust parser would read it from the .geojson.

CC @LLehner @quentinblampey

@quentinblampey
Copy link
Contributor

Hi @LucaMarconato!
In the current PR for the CLI (#239), they call ShapesModels.parse() inside spatialdata-io instead of moving the function itself. Which option do you prefer? I'm fine with both.

(just to know if we need to do make PR in spatialdata, or update the spatialdata-io PR)

@LucaMarconato
Copy link
Member Author

I think it will be cleaner to move the function inside spatialdata-io so that the parser is detached from reading from files. I will review the PRs shortly after the incoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants