Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix .A removal #3084

Merged
merged 4 commits into from
Jun 3, 2024
Merged

fix .A removal #3084

merged 4 commits into from
Jun 3, 2024

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented May 31, 2024

  • Release notes not necessary because:

Two different fixes:

  1. The np.asarray cases are when we e.g. had spmat.sum(axis=1).A (i.e. a dense matrix). I could also leave these as .A.
  2. the .toarray() cases are when we converted a sparse matrix to dense directly.

@flying-sheep flying-sheep added this to the 1.10.2 milestone May 31, 2024
@flying-sheep flying-sheep requested a review from ilan-gold May 31, 2024 11:15
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.85%. Comparing base (5dc489d) to head (6ba3676).
Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
scanpy/external/exporting.py 0.00% 2 Missing ⚠️
scanpy/preprocessing/_combat.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3084   +/-   ##
=======================================
  Coverage   75.85%   75.85%           
=======================================
  Files         110      110           
  Lines       12531    12531           
=======================================
  Hits         9506     9506           
  Misses       3025     3025           
Files with missing lines Coverage Δ
scanpy/plotting/_qc.py 86.84% <100.00%> (ø)
scanpy/plotting/_tools/paga.py 66.98% <100.00%> (ø)
scanpy/preprocessing/_pca.py 92.93% <100.00%> (ø)
scanpy/preprocessing/_scrublet/core.py 92.90% <ø> (ø)
scanpy/preprocessing/_scrublet/sparse_utils.py 89.28% <100.00%> (ø)
scanpy/tools/_score_genes.py 85.54% <100.00%> (ø)
scanpy/preprocessing/_combat.py 90.83% <0.00%> (ø)
scanpy/external/exporting.py 13.44% <0.00%> (ø)

@flying-sheep flying-sheep self-assigned this Jun 3, 2024
@flying-sheep flying-sheep merged commit 874d99b into main Jun 3, 2024
10 of 14 checks passed
@flying-sheep flying-sheep deleted the fix-toarray-prop-removal branch June 3, 2024 09:17
@flying-sheep flying-sheep restored the fix-toarray-prop-removal branch June 3, 2024 09:22
@flying-sheep flying-sheep deleted the fix-toarray-prop-removal branch June 3, 2024 09:23
flying-sheep added a commit that referenced this pull request Jun 3, 2024
@scverse scverse deleted a comment from lumberbot-app bot Jun 3, 2024
flying-sheep added a commit that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-release jobs fail because scipy removed .A from csr/csc matrices
2 participants