Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logistic regression for perturbation space creation #538

Closed
Lilly-May opened this issue Feb 18, 2024 · 1 comment · Fixed by #560
Closed

Add logistic regression for perturbation space creation #538

Lilly-May opened this issue Feb 18, 2024 · 1 comment · Fixed by #560
Assignees
Labels
enhancement New feature or request

Comments

@Lilly-May
Copy link
Collaborator

Description of feature

We already offer several methods for creating the perturbation space. In addition to rather simple ones (Pseudobulk and Centroid Space), we also provide the DiscriminatorClassifierSpace where we train an MLP. Depending on the dataset, the training process can take quite long. Therefore, I would like to propose an additional ML-based approach, but one that is very simple.

I have done some tests with a logistic regression classifier using the Norman dataset, and the results look quite promising. Hence, I suggest adding a logistic regression classifier as an alternative to the MLP-based discrimination classifier.

Regarding the integration into the API, there are two options, and I would like to use this issue to start a discussion on which option people prefer:

  1. Integrating it as another independent class and renaming the DiscriminatorClassifierSpace to something that clearly indicates the use of an MLP.
  2. Integrating it into the already existing DiscriminatorClassifierSpace class and adding a parameter model, which can be either Regressor or MLP.
@Lilly-May Lilly-May added the enhancement New feature or request label Feb 18, 2024
@Zethson
Copy link
Member

Zethson commented Feb 18, 2024

I'd probably opt for option 2. Seems cleaner to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants