-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radius of circles is not affected by coordinate transformations #179
Comments
Line https://github.com/scverse/spatialdata-plot/blob/c1cc849eb8821d42326e34595dc7780f9186824f/src/spatialdata_plot/pl/render.py#L276 and onwards 👍 Essentially we add the artists and then apply the transformations. So I doubt you can easily transfer it to Napari :/ |
Thanks @timtreis. Actually I realized that in the |
Reported here: napari/napari#6649 |
Somehow the bug is still present, I will check this again after we merge the |
The bug was reintroduced with the multi_table PR, now it's fixed again, but the radius actually turns out to be incorrect, I will track this in another issue: #209. |
The behavior appears for instance with this dataset: https://github.com/giovp/spatialdata-sandbox/blob/main/visium/to_zarr.py.
A fix would be to use the same logic as here: https://github.com/scverse/spatialdata/blob/0446efff1ea8e5f31e5d901d83cf5eb38a72cc4d/src/spatialdata/_core/operations/transform.py#L364. If convenient, we can put this code in a helper function to avoid code duplication.
@timtreis @Sonja-Stockhaus can you please point me to the code used by
spatialdata-plot
to handle this case?The text was updated successfully, but these errors were encountered: