Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count fragment function counts duplicates #110

Open
lauradmartens opened this issue Jun 12, 2023 · 0 comments
Open

Count fragment function counts duplicates #110

lauradmartens opened this issue Jun 12, 2023 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@lauradmartens
Copy link

Describe the bug
The muon.atac.tl.count_fragments_features function uses the score in the fragment file to count fragments:

mx.data[i].append(int(fr.score)) # number of cuts per fragment (e.g. 2)

This score also includes all duplicated read pairs: https://support.10xgenomics.com/single-cell-atac/software/pipelines/latest/output/fragments, but we only want to use the unique fragments for downstream analysis and not the duplicates.

Expected behaviour
Only count the unique fragments by having:
mx.data[i].append(int(1))

@lauradmartens lauradmartens added the bug Something isn't working label Jun 12, 2023
@gtca gtca closed this as completed in a7320b7 Oct 17, 2024
gtca added a commit that referenced this issue Oct 17, 2024
From v0.2, count fragments by default and not reads.
See #110 for more details.
@gtca gtca reopened this Oct 17, 2024
@gtca gtca added this to the v0.2.0 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants