Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action for publish/upload on PyPI #88

Closed
grst opened this issue Jul 9, 2022 · 4 comments · Fixed by #170
Closed

Add action for publish/upload on PyPI #88

grst opened this issue Jul 9, 2022 · 4 comments · Fixed by #170
Milestone

Comments

@grst
Copy link
Collaborator

grst commented Jul 9, 2022

... or at least show in the docs how to set one up.

(initially suggested in #27, but that issue was about something else)

@grst grst added this to the v0.2.0 milestone Jul 9, 2022
@Zethson
Copy link
Member

Zethson commented Jul 25, 2022

Example: https://github.com/theislab/ehrapy/blob/development/.github/workflows/publish_package.yml

Need to replace the poetry build with the general build command and we're good to go. Need to add docs for the PyPI token

@adamgayoso
Copy link
Member

@ivirshup
Copy link
Member

ivirshup commented Oct 4, 2022

I would vote for showing how to do one over including the action.

Any idea how publishing via CI interacts with 2FA? pypa has been pushing for 2FA on uploads recently, and it will be required for anndata in the future.

@giovp
Copy link
Member

giovp commented Dec 9, 2022

Any idea how publishing via CI interacts with 2FA? pypa has been pushing for 2FA on uploads recently, and it will be required for anndata in the future.

interesting, but isn't 2FA only for critical projects (likely not newly generated projects with this template)?

I would vote for showing how to do one over including the action.

agree it's also a great pedagogical example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants