Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create issue templates #57

Closed
grst opened this issue May 14, 2022 · 15 comments · Fixed by #62
Closed

Create issue templates #57

grst opened this issue May 14, 2022 · 15 comments · Fixed by #62
Assignees
Milestone

Comments

@grst
Copy link
Collaborator

grst commented May 14, 2022

I think this repo should provide sensible default issue templates and link to the scverse discourse for help requests.

@grst grst self-assigned this May 17, 2022
@Zethson
Copy link
Member

Zethson commented May 18, 2022

New style tho, please. The actual forms

@grst
Copy link
Collaborator Author

grst commented May 18, 2022

I tried setting that up for scirpy. Feedback welcome!

https://github.com/scverse/scirpy/issues/new/choose

  • One issue I'm having is that I didn't find a way to make the version info collapsible. Either there's still some need for a markdown template within the form, or it won't be collapsed.

Once we are happy with it there, I'll copy it over to this repo.

@grst
Copy link
Collaborator Author

grst commented May 19, 2022

Link to a demo bug report:
scverse/scirpy#340

The section Version Information is quite unusable atm... maybe better to just use a plain text field. This might result in a very long issue, but 🤷

@Zethson
Copy link
Member

Zethson commented May 20, 2022

Great!

"plase paste the output between the backticks "

Typo

I'm a fan of the background text that you have in the other cells. Maybe this would also be something for the version information?
But this seems to be a decent version
image

Not collapsible, but I don't know how to make that work either.

@grst
Copy link
Collaborator Author

grst commented May 21, 2022 via email

@Zethson
Copy link
Member

Zethson commented May 21, 2022

Not sure whether all of our ecosystem packages require scanpy as a dependency. Some people may not know where this command comes from. I'd go with a "manual" approach (what you suggested)

@grst
Copy link
Collaborator Author

grst commented May 21, 2022

@Zethson
Copy link
Member

Zethson commented May 22, 2022

MuData version might also be relevant. Maybe we should ask users to run https://pypi.org/project/session-info/ ? This might be the most general version.

@ivirshup
Copy link
Member

sc.logging.print_versions() is just session-info.

Lesson learned from scanpy: get people to report all imported packages in the session where the bug occurred. This will save many hours of debugging.

@Zethson
Copy link
Member

Zethson commented May 24, 2022

sc.logging.print_versions() is just session-info.

Yeah, I'm aware. But then people don't need to have scanpy installed. In the future, some people may be using environments without scanpy.

@grst
Copy link
Collaborator Author

grst commented May 24, 2022

How confident are we about the state of session-info?

There's some evidence that in the past issues with that package weren't resolved very quickly:
https://gitlab.com/joelostblom/session_info/-/issues/8
https://gitlab.com/joelostblom/session_info/-/issues/10

Therefore, I have some concerns making it a depdendency

@ivirshup
Copy link
Member

ivirshup commented May 30, 2022

Stuff eventually got fixed, but there is also https://github.com/IBM/import-tracker which may be able to do the same (though I haven't tried it)

@grst
Copy link
Collaborator Author

grst commented Jun 4, 2022 via email

@ivirshup
Copy link
Member

ivirshup commented Jun 7, 2022

I think session-info is going to be the most mature and maintained option here.

@grst
Copy link
Collaborator Author

grst commented Jun 7, 2022

I'm still a bit wary of making it a dependency. This would mean that if session-info breaks, all scverse packages break (similar impact as e.g. numpy).

The actual code getting the version information seems quite straightforward. We could consider including the actual code in the template or putting it into a "scverse-tools" package (cf #72). Like that we would at least have control over it.

@grst grst added this to the v0.1.0 milestone Jul 9, 2022
@grst grst closed this as completed in #62 Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants