Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly setting title attribute of ngx-emoji to null is a problem #410

Closed
Nothorse opened this issue Nov 15, 2022 · 2 comments
Closed
Labels

Comments

@Nothorse
Copy link

We want to use ngx-emoji within a badge for reactions, similar to many chat systems. We provide a custom title for the whole component, but ngx-emoji sets the title attribute to "", which breaks the title on the surrounding div. It is also not possible to set the title from outside as title is not an input.

Please either make the title accessible or do not set the attribute at all if the value is null. This way containing divs can display their own title.

@scttcper
Copy link
Owner

🎉 This issue has been resolved in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Nothorse
Copy link
Author

Thanks. I'll have to wait with testing, we won't upgrade to angular 14 until it goes to LTS. I'll give feedback then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants