Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 7 - Labels cover lines and when scrolling moves with the scroll covering more #214

Closed
joshstallnick opened this issue May 10, 2019 · 7 comments
Labels

Comments

@joshstallnick
Copy link

When using this in Angular 7 the labels appear over available emojis which block them out. Also when scrolling the labels tend to move down to the middle of the set. I tried overriding the css but due to the dynamic generation it doesn't work as well.

High motion

Could we hook into when the category changes? It would be useful when the single category is set to true - then when changed I can just hide the innerHTML.

@scttcper
Copy link
Owner

scttcper commented May 10, 2019

does it happen for you in the demo?

@joshstallnick
Copy link
Author

joshstallnick commented May 10, 2019

This demo? https://typectrl.github.io/ngx-emoji-mart/

It works as expected.

I will setup a blank project, try to pull it in, and report back

@joshstallnick
Copy link
Author

Still had issues with a new project. I will mess with the dependencies and see if the Angular version matters.

Test repo I created: demo-emoji-mart-angular-7

@joshstallnick
Copy link
Author

Updated (and pushed) Angular update - still no dice

@joshstallnick
Copy link
Author

It seems with [isNative]=true it works just as intended.

The default of "apple" messes with the label positioning. Not sure if you want this closed and open as a different issue or just edit this to reflect the actual issue. Let me know

@UltraKenchie
Copy link

Confirming that it also covers the labels on this usage

<emoji-mart (emojiSelect)="selectEmoji($event)" set="twitter" title="Pick your emoji…"
   [showPreview]="false" [showSingleCategory]="true" [emojiTooltip]="true"></emoji-mart>

ngx-emoji-mart: v0.16.2

@scttcper
Copy link
Owner

🎉 This issue has been resolved in version 0.16.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants