Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support codemirror v6 #311

Open
varunpandurangaiah opened this issue Aug 3, 2022 · 7 comments
Open

Support codemirror v6 #311

varunpandurangaiah opened this issue Aug 3, 2022 · 7 comments

Comments

@varunpandurangaiah
Copy link

varunpandurangaiah commented Aug 3, 2022

My package.json

"@ctrl/ngx-codemirror": "^5.1.1",
"@types/codemirror": "5.60.5",
"codemirror": "^6.0.1",
Error: node_modules/@ctrl/ngx-codemirror/codemirror.component.d.ts:4:10 - error TS2305: Module '"codemirror"' has no exported member 'Editor'.

4 import { Editor, ScrollInfo, EditorFromTextArea, EditorChange } from 'codemirror';
           ~~~~~~


Error: node_modules/@ctrl/ngx-codemirror/codemirror.component.d.ts:4:18 - error TS2305: Module '"codemirror"' has no exported member 'ScrollInfo'.

4 import { Editor, ScrollInfo, EditorFromTextArea, EditorChange } from 'codemirror';
                   ~~~~~~~~~~


Error: node_modules/@ctrl/ngx-codemirror/codemirror.component.d.ts:4:30 - error TS2305: Module '"codemirror"' has no exported member 'EditorFromTextArea'.

4 import { Editor, ScrollInfo, EditorFromTextArea, EditorChange } from 'codemirror';
                               ~~~~~~~~~~~~~~~~~~


Error: node_modules/@ctrl/ngx-codemirror/codemirror.component.d.ts:4:50 - error TS2305: Module '"codemirror"' has no exported member 'EditorChange'.

4 import { Editor, ScrollInfo, EditorFromTextArea, EditorChange } from 'codemirror';
@xrasod
Copy link

xrasod commented Aug 5, 2022

We're having this issue to.

Edit: This resolved itself by simply downgrading codemirror 6.x, to latest 5.x.
npm install codemirror@^5.65.7 should do the trick.

@eriky
Copy link

eriky commented Oct 14, 2022

The docs should reflect that this works only with codemirror 5, so the install instructions should explicitly install codemirror 5.

@scttcper scttcper changed the title Angular 14 Has no Exported Member Support codemirror v6 Oct 14, 2022
@scttcper scttcper pinned this issue Oct 14, 2022
@emmamcarthur

This comment was marked as spam.

@jpike88
Copy link

jpike88 commented Dec 9, 2022

@scttcper raising the version of this package to v6 makes no sense. I updated to code mirror v6 assuming you were tracking their versioning, or at least sticking with v5 till your library could handle v6. This is a warning to others.

@scttcper
Copy link
Owner

scttcper commented Dec 9, 2022

that isn't how semver works

@scttcper
Copy link
Owner

scttcper commented Dec 9, 2022

As an update, i have no plans to upgrade this to codemirror 6 if anyone wants to take this on

@nzbin
Copy link

nzbin commented Jun 1, 2024

The CodeMirror v6 wrapper for Angular is here.
https://github.com/acrodata/code-editor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants