From bec07d4184d8ef87f9c22ac4d71b910e6ef2a691 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bigna=20H=C3=A4rdi?= Date: Tue, 28 Nov 2023 09:24:47 +0100 Subject: [PATCH] Rpc-api author: Clarify comments about blocking functions (#679) * add sync-api mode to comment * clarify comment --- src/api/rpc_api/author.rs | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/api/rpc_api/author.rs b/src/api/rpc_api/author.rs index 6208faa16..2d0dc46df 100644 --- a/src/api/rpc_api/author.rs +++ b/src/api/rpc_api/author.rs @@ -87,6 +87,8 @@ pub trait SubmitAndWatch { /// Submit an extrinsic an return a Subscription /// to watch the extrinsic progress. + /// + /// This method is blocking if the sync-api feature is activated async fn submit_and_watch_extrinsic( &self, extrinsic: UncheckedExtrinsicV4, @@ -99,6 +101,8 @@ pub trait SubmitAndWatch { /// Submit an encoded, opaque extrinsic an return a Subscription to /// watch the extrinsic progress. + /// + /// This method is blocking if the sync-api feature is activated async fn submit_and_watch_opaque_extrinsic( &self, encoded_extrinsic: &Bytes, @@ -123,7 +127,7 @@ pub trait SubmitAndWatch { /// - extrinsic hash /// - last known extrinsic (transaction) status /// - /// This method is blocking. + /// This method is blocking if the sync-api feature is activated async fn submit_and_watch_extrinsic_until( &self, extrinsic: UncheckedExtrinsicV4, @@ -154,7 +158,7 @@ pub trait SubmitAndWatch { /// - extrinsic hash /// - last known extrinsic (transaction) status /// - /// This method is blocking. + /// This method is blocking if the sync-api feature is activated async fn submit_and_watch_opaque_extrinsic_until( &self, encoded_extrinsic: &Bytes, @@ -170,7 +174,8 @@ pub trait SubmitAndWatch { /// - if watched until at least `InBlock`: /// hash of the block the extrinsic was included in /// - last known extrinsic (transaction) status - /// This method is blocking. + /// + /// This method is blocking if the sync-api feature is activated async fn submit_and_watch_extrinsic_until_without_events< Address, Call, @@ -196,7 +201,8 @@ pub trait SubmitAndWatch { /// - if watched until at least `InBlock`: /// hash of the block the extrinsic was included in /// - last known extrinsic (transaction) status - /// This method is blocking. + /// + /// This method is blocking if the sync-api feature is activated async fn submit_and_watch_opaque_extrinsic_until_without_events( &self, encoded_extrinsic: &Bytes,