Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build(contracts): add coverage report in /contracts #373

Merged
merged 15 commits into from
Mar 17, 2023
Merged

Build(contracts): add coverage report in /contracts #373

merged 15 commits into from
Mar 17, 2023

Conversation

ChuhanJin
Copy link
Contributor

  1. Purpose or design rationale of this PR
    add coverage report in /contracts

  2. Does this PR involve a new deployment, and involve a new git tag & docker image tag? If so, has tag in common/version.go been updated?
    no

  3. Is this PR a breaking change? If so, have it been attached a breaking-change label?
    no

@ChuhanJin
Copy link
Contributor Author

45% (-0.05%) vs master 45%

@github-actions
Copy link

github-actions bot commented Mar 16, 2023 •
edited
Loading

LCOV of commit 3834d3d during Contracts #200

Summary coverage rate:
  lines......: 43.6% (616 of 1412 lines)
  functions..: 59.8% (137 of 229 functions)
  branches...: no data found

Files changed coverage rate: n/a

@JJVincentJJ
finish (+6 squashed commits)
e1a9eb0 
Squashed commits:
[c008323] try
[2cae6ab] try
[b500ed5] try
[341c6b4] try
[c0ad812] try
[bbd6b8f] first draft
@ChuhanJin
Copy link
Contributor Author

45% (+0.05%) vs master 45%

zimpha
zimpha previously approved these changes Mar 16, 2023
View reviewed changes
@zimpha
Copy link
Member

zimpha commented Mar 16, 2023

Some path can be excluded in coverage report.

  • src/mocks
  • src/test
  • scripts
  • node_modules
  • lib

The way to do it: foundry-rs/foundry#2988 (comment)

0xmountaintop
0xmountaintop suggested changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@0xmountaintop 0xmountaintop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChuhanJin can you add exclusion rules according to @zimpha's suggestion? thx!

@ChuhanJin
Copy link
Contributor Author

44% (-0.32%) vs master 45%

@ChuhanJin
Copy link
Contributor Author

45% (-0.15%) vs master 45%

@0xmountaintop 0xmountaintop merged commit 0a404fe into develop Mar 17, 2023
@0xmountaintop 0xmountaintop deleted the add_cov_in_contracts branch March 17, 2023 10:20
0xmountaintop added a commit that referenced this pull request Mar 18, 2023
@ChuhanJin @JJVincentJJ @0xmountaintop
Build(contracts): add coverage report in /contracts (#373)
26e4363 
Co-authored-by: vincent <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmountaintop 0xmountaintop 0xmountaintop approved these changes

@zimpha zimpha zimpha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChuhanJin @zimpha @0xmountaintop @JJVincentJJ