Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backlog: remove mem trace #131

Closed
lispc opened this issue Jul 27, 2022 · 3 comments · Fixed by #134
Closed

backlog: remove mem trace #131

lispc opened this issue Jul 27, 2022 · 3 comments · Fixed by #134
Assignees

Comments

@lispc
Copy link

lispc commented Jul 27, 2022

after scroll-tech/scroll-prover#32 is used,

we can set vm.LogConfig{EnableMemory: true} to false. i guess doing this can reduce blockResult size 5-10times.

(I remember maybe we have to change 2 place? One is for the realtime websocket , the other is getBlockResultByHash fetching/regerating for old block trace? )

@mask-pp
Copy link

mask-pp commented Jul 29, 2022

Does that mean we can turning off Trace by params?

@mask-pp
Copy link

mask-pp commented Jul 29, 2022

Or just don't load memory trace?

@mask-pp mask-pp linked a pull request Jul 29, 2022 that will close this issue
@icemelon
Copy link
Member

@lispc I think #134 should be enough, right? we only need to disable the trace in the VM config. No need to change any API such as getBlockResultByHash.

@mask-pp mask-pp unpinned this issue Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants