Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize app hints implementation to assure consistent locations #467

Closed
2 tasks done
andrewtavis opened this issue Jun 16, 2024 · 1 comment
Closed
2 tasks done
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Jun 16, 2024

Terms

Description

As of now the app hint on the installation tab can at time have a different location in relation to the page contents than the app hints on the settings tab and about tab - see screenshot below:

Simulator Screenshot - iPhone SE (3rd generation) - 2024-06-16 at 13 21 26

In the screenshot below, notice that the app hint on the installation tab is slightly lower than the one on the settings tab. It would be ideal if the implementation for the installation tab was equivalent to that of the other tabs such that we can set the height consistently across application tabs.

Contribution

This issue is of relatively low priority, but would be nice to have at some point 😊 Happy to get to it myself or work with someone on it! This would also be a great good first issue for someone wanting to get into Scribe-iOS development!

@andrewtavis andrewtavis added feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 16, 2024
@andrewtavis
Copy link
Member Author

Closed by #473 🙌 Thanks so much @Mashtaleralia! Hope we can work with you again 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

1 participant