Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in pre-commit hook for running swiftlint on codebase #450

Closed
2 tasks done
andrewtavis opened this issue May 30, 2024 · 2 comments
Closed
2 tasks done

Add in pre-commit hook for running swiftlint on codebase #450

andrewtavis opened this issue May 30, 2024 · 2 comments
Assignees
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented May 30, 2024

Terms

Description

This issue would explore the potential of adding in pre-commit to the repo and using it to run our SwiftLint checks before commits. We'd want a hook that runs swiftlint --strict before all commits so that warnings are also triggered.

Contribution

Happy to support on this or get to it myself eventually! This would be a good first issue for someone who has a bit of Python or pre-commit setup experience :)

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 30, 2024
@andrewtavis
Copy link
Member Author

Note that there appears to be a file for this in SwiftLint here :) We'd maybe also need to add --strict to the execution.

@andrewtavis
Copy link
Member Author

Closed by #460 🥳 Thanks for this, @henrikth93! Such a great step towards very maintainable code :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants