Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop a method to ignore certain OPTIONAL selections in query checks #543

Open
2 tasks done
andrewtavis opened this issue Jan 5, 2025 · 1 comment
Open
2 tasks done
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

Something that I'm realizing is that we need to be able to expand the Wikidata queries to include some values that are not directly represented as forms for the lexeme. For instance:

  • For German verbs, if we want a perfect tense then we need to combine the auxiliary form with a conjugation of sein or haben (to be or to have), but then there is no form for this
    • We have "gegangen" for "gone", but for the conjugation table we want "bin gegangen" for the auxiliary verb
  • For English verb conjugations we want to create the full conjugation tables, but the data that's saved is just the base form of the verb and the third person singular form
    • This makes sense for saving data space, but not for making a complete data set at the end

An idea is that we place a comment in the OPTIONAL {} selection that then tells our check systems to ignore that selection - maybe something like # query-check-ignore.

Contribution

@axif0 could work on this as a part of Outreachy, but this issue wasn't discussed yet :) Happy to assist and review!

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed labels Jan 5, 2025
@andrewtavis
Copy link
Member Author

@axif0, let me know what your thoughts are on this. We can also discuss in the next sync or a call. Basic thing is that we'd like to get "all the conjugations" for verb data, but sometimes only part of the data is saved. If we include it in the query, then the forms check workflow will fail, so we need to figure out how to skip these workflows for some fields that we add in ourselves to make the resulting data set more complete :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

1 participant