Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a Wikidata lexemes dump required for scribe-data g -a #519

Closed
2 tasks done
andrewtavis opened this issue Dec 8, 2024 · 3 comments
Closed
2 tasks done

Make a Wikidata lexemes dump required for scribe-data g -a #519

andrewtavis opened this issue Dec 8, 2024 · 3 comments
Assignees
Labels
-priority- High priority feature New feature or request help wanted Extra attention is needed Outreachy Available for Outreachy participants

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Dec 8, 2024

Terms

Description

This issue is to require the presence of a Wikidata lexemes dump in order to run the scribe-data get --all command. There are a few steps here:

  • Add --wikidata-dump (-wd) as an argument for get
  • If the user passes a -wd argument with scribe-data g -a, then this file will be checked for and reported back to the user that it has been found using the functionality of Add check_lexeme_dump_prompt_download function to cli/utils.py #518
  • The user user doesn't pass a -wd argument, then we'll check to see if there's a Wikidata dump in the PWD
  • If there is no -wd argument and no dump in the PWD, then the user will be prompted to download a dump using the functionality in Add download Wikidata dump command to CLI #517
  • If the user doesn't choose to download the dump, then the functionality is canceled (the options for downloading are Yes/Cancel)

Contribution

@axif0 will be working on this as a part of Outrachy! 📶🚂

@andrewtavis andrewtavis added the feature New feature or request label Dec 8, 2024
@andrewtavis andrewtavis added help wanted Extra attention is needed -priority- High priority Outreachy Available for Outreachy participants labels Dec 8, 2024
@axif0
Copy link
Collaborator

axif0 commented Dec 10, 2024

Are we want like this?
If dump file is 20241106 and 20241030, existing latest dump will select 20241106.

if dump has latest and others .. we'll pick latest.. like here -

image

@andrewtavis
Copy link
Member Author

Looking good, @axif0! Can we rename the directory scribe_data_wikidata_lexeme_dumps so we don't have a dash in it? :)

@axif0 axif0 mentioned this issue Dec 11, 2024
2 tasks
@andrewtavis
Copy link
Member Author

Closed by #528 🏎️ Thanks for the quick work on the first three issue and for working towards our responsible Wikidata usage, @axif0!

@github-project-automation github-project-automation bot moved this from Todo to Done in Scribe Board Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-priority- High priority feature New feature or request help wanted Extra attention is needed Outreachy Available for Outreachy participants
Projects
Status: Done
Development

No branches or pull requests

2 participants