-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format export keys for JSON and SQLite #312
Comments
Feel free to write in here and I'll assign, @OmarAI2003 :) |
Fine Andrew I'll investigate this tomorrow |
So this issue is no longer blocked, right? |
Is not blocked, no |
@andrewtavis Should I change the tsv and csv column headers too? |
Ideally yes :) |
Thanks, @OmarAI2003! 😊 |
Done. But sadly some tests failed. |
Let me know if you need me to take a look :) |
Alright. I will. |
@andrewtavis Everything is fixed now! 🥳 |
Closed by #486 😊 Appreciate all the hard work and the discussion of the solution to get to this point, @OmarAI2003! |
Terms
Description
As of now Scribe-Data export JSON keys and SQLite columns that are camelCase. Ideally these would all be snake_case as this is a bit more in line with expectations for JSON and database column formatting - snake_case works for both, and we should choose one.
We should wait on this issue so that the convert functionality isn't effected by it.
convert
fromget
in Scribe-Data CLI #213Contribution
CC @OmarAI2003 who had interest in this :) Happy to review and assist as needed!
The text was updated successfully, but these errors were encountered: