Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent appearance of "Confirm your email" banner #1044

Open
jwzimmer-zz opened this issue Nov 19, 2016 · 2 comments
Open

Inconsistent appearance of "Confirm your email" banner #1044

jwzimmer-zz opened this issue Nov 19, 2016 · 2 comments
Milestone

Comments

@jwzimmer-zz
Copy link
Contributor

jwzimmer-zz commented Nov 19, 2016

Firefox 49.0.2, Mac OS 10.11, Staging (possibly also on Production; I haven't checked yet)

For user sldwgqds7889, I noticed that the confirm your email banner is showing up on the homepage (www) and profile page (scratchr2), but not on about (www) or the new TTT (/go) page (www). Presumably the banner should appear across all the pages until dismissed (and then it should disappear from all the pages).

captura de pantalla 2016-11-18 a las 10 52 02 pm

captura de pantalla 2016-11-18 a las 10 57 44 pm

@mewtaylor
Copy link
Contributor

This is in production – we have the banner tied to the splash page in www, rather than to the nav bar, which means it'll only appear on the splash page, rather than anywhere there's an nav bar.

So, this is definitely a bug, but probably not blocking the deploy IMHO.

@jwzimmer-zz
Copy link
Contributor Author

Removed staging label since it happens on both staging & production (thanks @mewtaylor).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants