Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRED bug: "Set Head ANIs using Messages.tbl" button doesn't set the Command head correctly #6379

Open
jlberman opened this issue Oct 1, 2024 · 2 comments · May be fixed by #6385
Open

FRED bug: "Set Head ANIs using Messages.tbl" button doesn't set the Command head correctly #6379

jlberman opened this issue Oct 1, 2024 · 2 comments · May be fixed by #6385
Assignees
Labels
fred A feature or issue related to the FReespace EDitor (FRED)

Comments

@jlberman
Copy link

jlberman commented Oct 1, 2024

How to reproduce: set a Command persona in mission settings.

Create a mission with a message sent by #Command.

Hit "set head anis using messages.tbl".

Command head is not set in the events manager.

@Goober5000 Goober5000 self-assigned this Oct 1, 2024
@Goober5000 Goober5000 added the fred A feature or issue related to the FReespace EDitor (FRED) label Oct 1, 2024
@Goober5000
Copy link
Contributor

Goober5000 commented Oct 1, 2024

Hmm, looking at my comments in that function, I see exactly what's happening. That function specifically only sets the heads for wingman personas. This is because, in my experience, many missions use the "Large Ship" or "Terran Command" persona for multiple ships with different heads, and would not want all of those ships to be changed to the same head.

Obviously in this situation there is a case to be made for setting heads for all personas. I could add some kind of selector that would allow the FREDder to control which category of personas this applied to.

@jlberman
Copy link
Author

jlberman commented Oct 1, 2024 via email

Goober5000 added a commit to Goober5000/fs2open.github.com that referenced this issue Oct 6, 2024
Augments the voice acting manager to handle non-wingman as well as wingman personas, plus limit operations to a specific persona.  This also modifies the editor to only increment the number of modifications when something *is* modified, not merely when something *could be* modified but is currently the expected value.

Resolves scp-fs2open#6379.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fred A feature or issue related to the FReespace EDitor (FRED)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants