Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request->stop() is not appearing to be called #90

Closed
asgrim opened this issue Oct 10, 2019 · 0 comments · Fixed by #91
Closed

Request->stop() is not appearing to be called #90

asgrim opened this issue Oct 10, 2019 · 0 comments · Fixed by #91
Assignees
@asgrim
Labels
bug Something isn't working

Comments

@asgrim
Copy link
Collaborator

asgrim commented Oct 10, 2019

I discovered whilst adding memory_usage to the collected data - #66 (comment) - that the Request->stop() method is never actually being called, which means the timestamp (and memory_usage, if merged) is not actually being set there. Investigate why, and fix.
@asgrim asgrim added the bug Something isn't working label Oct 10, 2019
@asgrim asgrim self-assigned this Oct 10, 2019
@asgrim asgrim mentioned this issue Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asgrim asgrim

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing request stop timestamp scoutapp/scout-apm-php
1 participant
@asgrim