Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HEROKU_SLUG_COMMIT environment variable #73

Closed
asgrim opened this issue Sep 24, 2019 · 1 comment · Fixed by #88
Closed

Support HEROKU_SLUG_COMMIT environment variable #73

asgrim opened this issue Sep 24, 2019 · 1 comment · Fixed by #88
Assignees
Labels
enhancement New feature or request nice to have This is a "nice to have" feature - not a critical requirement

Comments

@asgrim
Copy link
Collaborator

asgrim commented Sep 24, 2019

The docs state:

  • If you are using Heroku, enable Dyno Metadata.
    This adds a HEROKU_SLUG_COMMIT environment variable to your dynos, which Scout then
    associates with deploys.

I don't think this is currently supported, so presumably we should add this as a feature.

@asgrim asgrim added enhancement New feature or request nice to have This is a "nice to have" feature - not a critical requirement labels Sep 24, 2019
@cschneid
Copy link
Contributor

Yes, this is how the obtaining the SHA for Deploy tracking works on heroku. In the python agent, we look at revision_sha config first, then check this env var.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nice to have This is a "nice to have" feature - not a critical requirement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants