Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using symfony/process to launch core agent #45

Open
asgrim opened this issue Sep 2, 2019 · 2 comments
Open

Consider using symfony/process to launch core agent #45

asgrim opened this issue Sep 2, 2019 · 2 comments
Labels
enhancement New feature or request nice to have This is a "nice to have" feature - not a critical requirement

Comments

@asgrim
Copy link
Collaborator

asgrim commented Sep 2, 2019

The core-agent is launched with a basic exec at the moment. If we don't mind depending on another a third party library, we could use the very powerful symfony/process component to manage this. We can gather output, check the PID status etc. to ensure the agent has launched much better.

@asgrim asgrim added the enhancement New feature or request label Sep 2, 2019
@asgrim asgrim self-assigned this Sep 2, 2019
@cschneid
Copy link
Contributor

cschneid commented Sep 3, 2019

Right now, the core agent is intended to be a launch & daemonize sequence, so it's not attached to the running php/python process at all.

The design is that we don't want a single php process as the owners of the core agent process, where they take it down during an app server restart, or any individual worker restarting. Also a rarer, but supported, case is to have both a PHP & a Python app on the same server, both being served by the same core agent.

@asgrim
Copy link
Collaborator Author

asgrim commented Sep 3, 2019

The main thing this would help with is if "my" PID launched the agent, that we'll be able to verify if we launched it or not (right now, we launch it and shrug it off). It's a nice to have, but would make that part of the process launching a bit cleaner :)

@asgrim asgrim removed their assignment Sep 5, 2019
@asgrim asgrim added the nice to have This is a "nice to have" feature - not a critical requirement label Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nice to have This is a "nice to have" feature - not a critical requirement
Projects
None yet
Development

No branches or pull requests

2 participants