Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve configuration loading/handling #251

Open
asgrim opened this issue Dec 28, 2021 · 0 comments
Open

Improve configuration loading/handling #251

asgrim opened this issue Dec 28, 2021 · 0 comments
Labels
enhancement New feature or request nice to have This is a "nice to have" feature - not a critical requirement

Comments

@asgrim
Copy link
Collaborator

asgrim commented Dec 28, 2021

The current Config implementation is difficult to consume; pretty much everything is mixed, since even the CoerceType is not carried through in any way static analysers can understand.

This has led to contributors implementing various wrappers, especially for more complex types, such as \Scoutapm\Config\Helper\RequireValidFilteredParameters, \Scoutapm\Config\IgnoredEndpoints, as well as a LOT of downstream type checks.

Investigate an overhaul which would allow us to keep the same configuration sources we support, but the API for fetching the config values internally would be improved and type-safe.
@asgrim asgrim added enhancement New feature or request nice to have This is a "nice to have" feature - not a critical requirement labels Dec 28, 2021
@asgrim asgrim mentioned this issue Dec 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request nice to have This is a "nice to have" feature - not a critical requirement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asgrim