Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Span::INSTRUMENT_* constants in 6.0.0 #196

Closed
asgrim opened this issue Nov 2, 2020 · 1 comment · Fixed by #206
Closed

Remove Span::INSTRUMENT_* constants in 6.0.0 #196

asgrim opened this issue Nov 2, 2020 · 1 comment · Fixed by #206
Labels
BC BREAK This PR contains a BC break; major version should be incremented enhancement New feature or request

Comments

@asgrim
Copy link
Collaborator

asgrim commented Nov 2, 2020 •
edited
Loading

In 5.1.0 release, we deprecated Span::INSTRUMENT_* constants (see #194) and introduced the exactly-equivalent SpanReference::INSTRUMENT_* constants (since Span is technically @internal we cannot provide API promise, but this migration path allows semver compliance for those constants nonetheless).
@asgrim asgrim added enhancement New feature or request BC BREAK This PR contains a BC break; major version should be incremented labels Nov 2, 2020
@asgrim asgrim mentioned this issue Feb 23, 2021
Merged
@asgrim
Copy link
Collaborator Author

asgrim commented Feb 23, 2021

These constants are now removed in #206 .

If you have not already updated them, please replace respective usages of:

\Scoutapm\Events\Span\Span::INSTRUMENT_CONTROLLER
\Scoutapm\Events\Span\Span::INSTRUMENT_JOB
\Scoutapm\Events\Span\Span::INSTRUMENT_MIDDLEWARE

with

\Scoutapm\Events\Span\SpanReference::INSTRUMENT_CONTROLLER
\Scoutapm\Events\Span\SpanReference::INSTRUMENT_JOB
\Scoutapm\Events\Span\SpanReference::INSTRUMENT_MIDDLEWARE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC BREAK This PR contains a BC break; major version should be incremented enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@asgrim