Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy array arguments if safe in safely_copy_argument_zval_as_scalar #76

Open
asgrim opened this issue May 10, 2021 · 0 comments
Open

Copy array arguments if safe in safely_copy_argument_zval_as_scalar #76

asgrim opened this issue May 10, 2021 · 0 comments
Labels
enhancement New feature or request nice to have

Comments

@asgrim
Copy link
Collaborator

asgrim commented May 10, 2021

At the moment array types are turned into the string "array". An improvement on this mechanism would be to descend into the array, and safely convert the array items too (recursively).

This is useful for stuff like Predis\Client->__call so we know the parameters used. At the moment, we'd get an argv of string("set"), string("array") which is ok, but it would be more helpful to convert this to string("set"), array{string("foo"), string("bar")}.

@asgrim asgrim added enhancement New feature or request nice to have labels May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nice to have
Projects
None yet
Development

No branches or pull requests

1 participant