Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not use Alternative instead of custom <|> operator? #18

Open
bsima opened this issue Feb 15, 2019 · 0 comments
Open

Why not use Alternative instead of custom <|> operator? #18

bsima opened this issue Feb 15, 2019 · 0 comments

Comments

@bsima
Copy link

bsima commented Feb 15, 2019

I think the custom operator should be replaced with an Alternative instance: https://github.com/scotty-web/wai-middleware-static/blob/master/Network/Wai/Middleware/Static.hs#L96-L99

Of course you'll also need Functor and Applicative, not sure how hard that would be to implement. If you'll accept a patch for this, let me know and I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant