Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly support project pages and baseurl #1

Closed
scottdorman opened this issue Mar 8, 2019 · 1 comment
Closed

Properly support project pages and baseurl #1

scottdorman opened this issue Mar 8, 2019 · 1 comment
Assignees
@scottdorman
Labels
bug Something isn't working

Comments

@scottdorman
Copy link
Owner

scottdorman commented Mar 8, 2019 •
edited
Loading

Project pages publish under a subfolder and require setting the baseurl property in config.yml. The page links need to be updated to use relative_url instead of site.url in most places. There are a few places where site.url still needs to be prepended.

See https://byparker.com/blog/2014/clearing-up-confusion-around-baseurl and github/pages-gem/issues/460 for more information.
@scottdorman scottdorman added the bug Something isn't working label Mar 8, 2019
@scottdorman scottdorman self-assigned this Mar 8, 2019
@scottdorman
Copy link
Owner Author

This is fixed in commit 900b97a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottdorman scottdorman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scottdorman