Fine tuning for esp32s3 #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brushknight
commented
Oct 22, 2023
brushknight
commented
- exposed strain SCK and DO
- limit screen brightness to UINT8_MAX (limit for s3)
- added option to use uart to usb for s3
- bump nanopb/Nanopb @ 0.4.7
- fixed SPI bus alias and DMA channel for s3
- exposed strain SCK and DO - limit screen brightness to UINT8_MAX (limit for s3) - added option to use uart to usb for s3 - bump nanopb/Nanopb @ 0.4.7 - fixed SPI bus alias and DMA channel for s3
scottbez1
reviewed
Oct 28, 2023
|
Looks great, thanks! If you don't mind, I'll make a handful of small style and other updates before merging. |
…S3 to a SK_FORCE_UART_STREAM flag, avoid redefinition warnings by moving build flags out of base config
scottbez1
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.