BET-4061: Apollo 0.23.1

[ketenshi]

Updated Apollo Version
Release notes: https://github.com/apollographql/apollo-ios/releases

They made some fixes to the Watcher and Caching, which should fix some issues we are currently facing.

---

Created this branch off connect and then rebased on top of upstream/master

Afterwards merged connect into this branch.

No new merge conflicts other than from the commits we had before.

[tapi]

agreed, Also curios why we have connect/disconnect and the socket public

[ketenshi]

We connect/disconnect when we update the auth token. Otherwise from what I remember we'll have to create a new ApolloClient each time.

[tapi]

and that is dependency injected all the way down so sending a new one is a PITA.

LOL. we don't use the methods we added. we use the exposed web socket directly

private func disconnectWebsockets(reconnect: Bool = false) {
        let websockets = queryRouter.endpoints.compactMap { $0.websocketTransport?.websocket as? WebSocket }
        websockets.forEach { $0.disconnect() }
        if reconnect {
            websockets.forEach { $0.connect() }
        }
    }

[ketenshi]

Lol we can discard that change then.

[tapi]

And it looks like that is the only time we use websocket so it's likely the methods would be sufficient and probably an easier sell upstream.

[tapi]

I wonder if instead of connect/disconnect we can use the existing close and add reopen seems like maybe that would solve our use of refreshInterval as well

[ketenshi]

Looking at their closeConnection() it sends a termination message to the server and clears out subscriptions and queues. I think we'll need to do some investigation and testing there as a separate PR.

[ketenshi]

Created https://jira.thescore.com/browse/BET-4109 to track pushing the changes upstream