Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] support volume subpath #166

Closed
ndeloof opened this issue Jul 10, 2024 · 3 comments · Fixed by #169
Closed

[FEATURE] support volume subpath #166

ndeloof opened this issue Jul 10, 2024 · 3 comments · Fixed by #169
Assignees
@astromechza
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ndeloof
Copy link

ndeloof commented Jul 10, 2024

Documentation says:

Volume mounts with path will be rejected. Docker compose doesn't support sub-path mounts for Docker volumes."

this isn't true (since compose-spec/compose-go#594)

      - type: volume
        source: foo
        target: /app
        volume:
          subpath: etc/settings
@astromechza
Copy link
Member

hah! well spotted @ndeloof and thanks for the contribution to compose 👍
We'll get this fixed up.

@ndeloof
Copy link
Author

ndeloof commented Jul 10, 2024

also, feel free to add score-compose to the list of users for compose-go library on https://github.com/compose-spec/compose-go?tab=readme-ov-file#used-by

@astromechza
Copy link
Member

👍 Done in compose-spec/compose-go#660

@astromechza astromechza added enhancement New feature or request good first issue Good for newcomers labels Jul 10, 2024
@astromechza astromechza mentioned this issue Jul 12, 2024
Merged
@astromechza astromechza self-assigned this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astromechza astromechza

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support subpath on docker or bind volumes score-spec/score-compose
2 participants
@ndeloof @astromechza