Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in CleanCSS cause abort with no diagnostics. #85

Open
paulmer opened this issue Mar 31, 2020 · 0 comments
Open

Errors in CleanCSS cause abort with no diagnostics. #85

paulmer opened this issue Mar 31, 2020 · 0 comments

Comments

@paulmer
Copy link

paulmer commented Mar 31, 2020

An error processing a CSS file (for example, an @import of a non-existing file) causes gulp-clean-css to abort without any diagnostic message.

According to https://gulpjs.com/docs/en/getting-started/async-completion under "Using an error-first callback", the cb function can be passed an Error object, but gulp-clean-css is passing a string on line 37: return cb(errors.join(' '));. Wrapping the string in an error object fixes the problem: return cb(new Error(errors.join(' ')));.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant