Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we pull/build only released packages #31

Open
hhorak opened this issue May 29, 2017 · 4 comments
Open

Ensure we pull/build only released packages #31

hhorak opened this issue May 29, 2017 · 4 comments

Comments

@hhorak
Copy link
Member

hhorak commented May 29, 2017

When using rhpkg downloader strategy, it is not clear what hash was used to already published build and which were not yet published (and what is more important, might contain some embargoed information). So, for rebuilding published RPMs (like RHSCL rebuilds for CentOS), it would be necessary to either:

  • find out which hashes match the published builds
  • or use SRPM repository that contains published RPMs only
@junaruga
Copy link
Member

Maybe you want to prevent the package that is not published to be built on public build system such as Copr, right?

And

what hash was used to already published

hash?

Like this?
https://www.apache.org/dist/httpd/httpd-2.2.32.tar.gz.sha1

19e94b8c9e727cc16b75795814c5b0e27ebc08d5 *httpd-2.2.32.tar.gz

@junaruga
Copy link
Member

or use SRPM repository that contains published RPMs only

Adding additonal download option to download SRPMs from repository. This looks easier to implement.

@junaruga
Copy link
Member

junaruga commented May 29, 2017

@hhorak as we talked today, the solution is implementing below 2 new features.

  • Adding download option to download SRPM.
  • Output warning message "You may access public build service to build packages downloaded by rhpkg." if user is running RPM List Builder on below cases. Basically it is user's responsibility.
    • download: using rhpkg command (rhpkg option or custom option including rhpkg in custom YAML file) AND
    • build: using copr-cli or koji command (copr option or custom option including copr-cli or koji in custom YAML file).

@hhorak
Copy link
Member Author

hhorak commented Jun 1, 2017

That looks good to me, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants