Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MergeNamePartsWithComma middleware #421

Closed
1 of 2 tasks
mlutze opened this issue Nov 21, 2023 · 2 comments
Closed
1 of 2 tasks

Add MergeNamePartsWithComma middleware #421

mlutze opened this issue Nov 21, 2023 · 2 comments
Assignees
Labels

Comments

@mlutze
Copy link
Contributor

mlutze commented Nov 21, 2023

Is your feature request related to a problem? Please describe.
Generally I would expect SplitNameParts and MergeNameParts to be semantic inverses. Consider:

last = [Peyton Jones], first = [Simon]
- merge -
Simon Peyton Jones
- split -
last = [Jones], first = [Simon Peyton]

We've lost the information that "Peyton Jones" was the full last name.

Describe the solution you'd like
I'd like to have a MergeNameParts middleware that does the merge in the comma style. This would preserve the first/last information better.

Furthermore, due to the drawbacks of the space-separated strategy, I think the comma style should be the default.

Use cases
This is important for any program that needs to manipulate names, as correctness of names can be lost when merging them back.

Describe alternatives you've considered
The first-name-first order could possibly be maintained by surrounding the whole last name with braces (Simon {Peyton Jones}). I'm not sure this actually works, and it also has implications on capitalization, since I think some programs using BibTeX consider braces when capitalizing names, etc.

Remaining Questions (Optional)
Please tick all that apply:

  • I would be willing to to contribute a PR to fix this issue.
  • This issue is a blocker, I'd be greatful for an early fix.
@MiWeiss
Copy link
Collaborator

MiWeiss commented Nov 21, 2023

Thanks for reporting.

Furthermore, due to the drawbacks of the space-separated strategy, I think the comma style should be the default.

I agree, this sounds reasonable.

We certaintly have to be able to provide a configuration that does the space-style merging though, as this what we provide in the corresponding v1 customization, if I recall correctly. Thus, people migrating from v1 may be looking for this!

Thanks a lot for willing to provide a PR!

The first-name-first order could possibly be maintained by surrounding the whole last name with braces (Simon {Peyton Jones})

I also like this proposition. We just have to be a little careful w.r.t. "von" and "jr" parts, which are sometimes hard to tell from 2-part last names. A look at the bibtex specs might help. Also this is a good reference regarding bibtex names...

Would you be willing to also open a PR for this? If so, feel free to do so in a separate PR, as you please. Feel also free to extract a standalone issue for this second part.

@MiWeiss
Copy link
Collaborator

MiWeiss commented Feb 14, 2024

Correct me if I'm wrong, but if I recall correctly this is closed by #422?

@MiWeiss MiWeiss closed this as completed Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants