-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect duplicate types #138
Comments
Can you clarify what is duplicate and what broke? Having types with identical names in different modules sounds like a valid thing? |
See the linked PR. There were two identically named types and some providers used one, other used the other. This meant that those providers did not connect into a pipeline as expected. |
Yes, but can you clarify what Sciline could/should do about this? Isn't it a valid application to have types of the same naming in different packages or modules? |
Valid but confusing. |
Makes sense. Do you want to transfer the issue to another project then? |
scipp/esssans#102 had a duplicate type. This can break pipelines. Can we detect them automatically somehow? Maybe we can use a heuristic to search for them in source code or hook into a linter to list all type definitions. This could be hooked into pre-commit.
The text was updated successfully, but these errors were encountered: