Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should horizontal graphs created with visualize be the default? #39

Open
nvaytet opened this issue Jun 16, 2024 · 1 comment
Open

Should horizontal graphs created with visualize be the default? #39

nvaytet opened this issue Jun 16, 2024 · 1 comment

Comments

@nvaytet
Copy link
Member

nvaytet commented Jun 16, 2024

We seem to use graph_attr={'rankdir': 'LR'} in all our workflows. Should this just be the default behaviour of visualize?

In the sciline docs, we seem to mostly use vertical graphs, which makes sense with the page layout (and the graphs tend to be relatively short).
Would be a little annoying (confusing?) to have to use graph_attr={'rankdir': 'TB'} in the docs, but I feel the UX gain for reduction workflows would be worth it?

@SimonHeybrock
Copy link
Member

SimonHeybrock commented Jun 17, 2024

Another option is to do this in the ESS InstrumentWorkflow wrappers of sciline.Pipeline, since this may just be the case for our applications(alongside other convenience, such as default target keys, ...).

@SimonHeybrock SimonHeybrock transferred this issue from scipp/sciline Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants