Bug in uncompress from scilpy/tractograms/uncompress.pyx

[AntoineTheb]

There is a bug in the uncompress function where more points_to_idx may be returned than there are points in the streamline.

Here is an example script to test

import os

from scilpy.io.streamlines import load_tractogram
from scilpy.tractograms.uncompress import uncompress

# Tests should be run locally so that you have the testing data loaded in your home directory
home = os.path.expanduser('~')
sft = load_tractogram(f'{home}/.scilpy/filtering/bundle_all_1mm.trk', 'same')

sft.to_vox()
sft.to_corner()

indices, points_to_idx = uncompress(sft.streamlines, return_mapping=True)
streamline_lengths, mapping_lengths = [len(s) for s in sft.streamlines], [len(m) for m in points_to_idx]

for s,m in zip(streamline_lengths, mapping_lengths):
    assert s == m, (s,m)

Should give you an error.

AssertionError: (130, 131)

[EmmaRenauld]

Self-reminder...
Pour hackaton: voir avec moi les tests que j'avais commencé à faire dans ma branche ici. Pourrait peut-être aider à tester des choses.
https://github.com/EmmaRenauld/scilpy/tree/streamline_and_mask_tests