FIX BorddelineSMOTE-2 use the full dataset to generate new sample #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… synthetic sample
solegalli
reviewed
Jul 11, 2023
|
|
||
| self.nn_k_.fit(X_to_sample_from) | ||
| nns = self.nn_k_.kneighbors(X_danger, return_distance=False)[:, 1:] | ||
| X_new, y_new = self._make_samples( |
There was a problem hiding this comment.
This implementation does not fully reflect the description of Borderline smote 2 in the paper. The paper says that to create the samples by interpolation between the template of the minority and a neigbhour of the majority, it multiplies by a factor between 0 and 0.5 (instead of 0-1) to ensure the synthetic data is closer to the minority.
If I understand this code correctly, we are multiplying everything by a factor between 0 and 1. Pls correct me if I am wrong.
There was a problem hiding this comment.
Nop, indeed. I forgot to look at the next page of the article. I will try to propose a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #861
Make sure that we use the full dataset to generate new samples in
BorderlineSMOTEversion 2.