Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: models should not be wrapped in a ListOffsetForm #841

Merged
merged 3 commits into from
Feb 23, 2023
Merged

fix: models should not be wrapped in a ListOffsetForm #841

merged 3 commits into from
Feb 23, 2023

Conversation

ioanaif
Copy link
Collaborator

@ioanaif ioanaif commented Feb 23, 2023

Fix for #814

@ioanaif ioanaif changed the title fix:models should not be wrapped in a ListOffsetForm fix:Models should not be wrapped in a ListOffsetForm Feb 23, 2023
@ioanaif ioanaif changed the title fix:Models should not be wrapped in a ListOffsetForm fix: Models should not be wrapped in a ListOffsetForm Feb 23, 2023
@ioanaif ioanaif changed the title fix: Models should not be wrapped in a ListOffsetForm fix: models should not be wrapped in a ListOffsetForm Feb 23, 2023
jpivarski
jpivarski approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(The PR review is on Zoom. We talked about all of this, and it looks great!)

@jpivarski jpivarski linked an issue Feb 23, 2023 that may be closed by this pull request
uproot fails to read branch of TVector3 created with RDF::Snapshot #814
Closed
@jpivarski jpivarski merged commit 8f7bf18 into main Feb 23, 2023
@jpivarski jpivarski deleted the ioanaif/fix-issue-814 branch February 23, 2023 14:26
@jpivarski
Copy link
Member

@all-contributors please add @ioanaif for code

@allcontributors allcontributors bot mentioned this pull request Mar 1, 2023
Merged
@allcontributors
Copy link
Contributor

@jpivarski

I've put up a pull request to add @ioanaif! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uproot fails to read branch of TVector3 created with RDF::Snapshot
2 participants
@ioanaif @jpivarski