fix: regularize ROOT type aliases to C fundamental type names. #717

jpivarski · 2022-09-19T22:34:24Z

No description provided.

jpivarski · 2022-09-19T23:05:33Z

It is my belief that this will pass tests when #719 is merged in. Therefore,

test: adjust for boost-histogram 1.3.2's _storage_type deprecation. #719 gets approved and merged into main.
This PR updates to main.
The tests re-run and pass.
This PR gets approved and merged into main.

agoose77 · 2022-09-20T07:44:21Z

If #718 gets merged, I'm happy with this being merged. It looks like an unrelated test deprecation warning that's failing the CI.

…p-types

This improves safety and readability

for more information, see https://pre-commit.ci

jpivarski · 2022-09-20T21:17:03Z

Thanks! #717 and #718 are in sync, so I'll merge them both.

fix: regularize ROOT type aliases to C fundamental type names.

6315ab7

jpivarski linked an issue Sep 19, 2022 that may be closed by this pull request

Cannot read TParameter<Long64_t> #707

Closed

jpivarski mentioned this pull request Sep 19, 2022

fix: regularize ROOT type aliases to C fundamental type names (v4). #718

Merged

jpivarski requested a review from agoose77 September 19, 2022 23:04

jpivarski and others added 3 commits September 20, 2022 11:29

Merge branch 'main' into jpivarski/regularize-root-type-aliases-to-cp…

2dfd1e7

…p-types

wip: use translation table instead of if-chain

94d4312

This improves safety and readability

[pre-commit.ci] auto fixes from pre-commit.com hooks

7d9813c

for more information, see https://pre-commit.ci

jpivarski merged commit cc271d7 into main Sep 20, 2022

jpivarski deleted the jpivarski/regularize-root-type-aliases-to-cpp-types branch September 20, 2022 21:17

Provide feedback